Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Swapped the Y and Z keys which were in the wrong places on the s… #365

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

LuisSebastianG
Copy link
Contributor

…Spanish keyboard in ESInterfaceVariables.swift lines 35 and 37

Contributor checklist


Description

  • Swapped the y and z variables in the spanish keyboard so they're in the correct places on the keyboard.
  • It was tested on the xcode simulator of an ipad.

Related issue

…panish keyboard in ESInterfaceVariables.swift lines 35 and 37
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-iOS repo
  • The CHANGELOG has been updated with a description of the changes for the upcoming release (if necessary)

Copy link
Member

@henrikth93 henrikth93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well, @LuisSebastianG! Thanks for the review help as well, @henrikth93 :) :)

@andrewtavis andrewtavis merged commit 1ea86c8 into scribe-org:main Oct 6, 2023
1 check passed
@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants